REF: share code ArrayManager/BlockManager #40338
Merged
+53
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
requested changes
Mar 10, 2021
| return tuple(len(ax) for ax in self.axes) | ||
|
|
||
| def _normalize_axis(self, axis): | ||
| # switch axis to follow BlockManager logic |
There was a problem hiding this comment.
Can you leave this one in their respective classes?
Although the code is the same, they actually have the opposite purpose (they are used in different places in AM and BM, which probably points to the fact I should have named them differently ..), and while converting more methods to normal axis logic (xref #40075), the method will also change in AM code.
jreback
added
Internals
jorisvandenbossche
approved these changes
Mar 11, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.